This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix crash in _IO_wfile_sync (bug 20568)

* Andreas Schwab:

> On Mai 15 2019, Florian Weimer <fweimer@redhat.com> wrote:
>
>> * Andreas Schwab:
>>
>>> 	[BZ #20568]
>>> 	* libio/wfileops.c (_IO_wfile_sync): Correct last argument to
>>> 	__codecvt_do_length.
>>> 	* libio/Makefile (tests): Add tst-wfile-sync.
>>> 	($(objpfx)tst-wfile-sync.out): Depend on $(gen-locales).
>>> 	* libio/tst-wfile-sync.c: New file.
>>> 	* libio/tst-wfile-sync.input: New file.
>>
>> Would you please reference commit
>> 18d26750dd8fd328a78cf639fd0ec2494680a2a4 in the commit message?
>
> It's related, but not necessary.  The test will crash without that.

Ahh.  It might still make sense to mention that the bug becomes more
visible after that commit.  But the bug reference probably covers that.

Thanks,
Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]