This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5] support: Add xclock_gettime
On Wednesday 08 May 2019 at 15:46:48 +0200, Florian Weimer wrote:
> * Mike Crowe:
> > * support/xclock_gettime.c (xclock_gettime): New file. Provide
> > clock_gettime wrapper for use in tests that fails the test rather
> > than returning failure.
> >
> > * support/xtime.h: New file to declare xclock_gettime.
> >
> > * support/Makefile: Add xclock_gettime.c.
> >
> > * support/README: Mention xtime.h.
>
> Patch looks good, but the commit message above looks a bit odd (I mean
> the indentation).
I just copied and pasted from the ChangeLog entry, so each line starts with
a tab. This seems to be quite common looking through the existing history
(e.g. 52faba65f84ee5a8d82ff813bcfa0ee5f4d480cf) but I can reformat it to
remove the tab if required. I could also add some explanatory text before
the ChangeLog entry if you think that would be better.
> Do you have an account on sourceware? If yes, please push this
> independently of the rest.
No, I do not.
Thanks.
Mike.