This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 2/7] y2038: Introduce __ASSUME_64BIT_TIME define
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Stepan Golosunov <stepan at golosunov dot pp dot ru>
- Cc: Lukasz Majewski <lukma at denx dot de>, <libc-alpha at sourceware dot org>, Arnd Bergmann <arnd at arndb dot de>, Paul Eggert <eggert at cs dot ucla dot edu>
- Date: Tue, 7 May 2019 15:43:56 +0000
- Subject: Re: [PATCH v2 2/7] y2038: Introduce __ASSUME_64BIT_TIME define
- References: <20190429104613.16209-1-lukma@denx.de> <20190429104613.16209-3-lukma@denx.de> <alpine.DEB.2.21.1904292138430.21580@digraph.polyomino.org.uk> <20190430110505.2a0c7d1a@jawa> <20190430214748.rzjlcu3f3hdyqnhw@sghpc.golosunov.pp.ru> <20190502105108.541fe118@jawa> <20190502115459.d3qwvhvmzl6c5kmo@sghpc.golosunov.pp.ru> <20190502155549.2f7bf82d@jawa> <20190506153844.77cad546@jawa> <20190506162659.6d7e4a59@jawa> <20190506193617.nd44jtdt4tty5few@sghpc.golosunov.pp.ru>
On Mon, 6 May 2019, Stepan Golosunov wrote:
> > > > > One way would be by defining __ASSUME_TIME64_SYSCALLS
> > > > > unconditionally on x32 and then defining __NR_clock_settime64 to
> > > > > __NR_clock_settime when __ASSUME_TIME64_SYSCALLS is defined while
> > > > > __NR_clock_settime64 isn't.
>
> I think now that with this scheme __ASSUME_TIME64_SYSCALLS should be
> defined unconditionally for the __WORDSIZE==64 case too. With this
That's certainly one possibility for how to implement things - define all
the __NR_*64 to the older __NR_* in the case where the older __NR_*
already handle 64-bit time.
If that approach is used, the comment on __ASSUME_TIME64_SYSCALLS then
needs to describe *two* different concepts very carefully, without
conflating them: the set of syscall ABIs with the new syscalls, and the
set of syscall ABIs which have 64-bit time functionality for a given set
of interfaces, with the __NR_*64 names for those interfaces being
available within glibc (but where it might be either old or new syscalls
behind those names in glibc).
--
Joseph S. Myers
joseph@codesourcery.com