Re: [PATCH] Makeconfig: Move -Wl,-rpath-link options before library references

[Florian Weimer <fweimer at redhat dot com>]

* Carlos O'Donell:

>>   $(call after-link,$@)
>>   endef
>>   define +link-tests
>> @@ -552,6 +552,15 @@ ifeq (yes,$(build-shared))
>>   link-libc-rpath = -Wl,-rpath=$(rpath-link)
>>   link-libc-rpath-link = -Wl,-rpath-link=$(rpath-link)
>>   +# For programs which are not tests, $(link-libc-rpath-link) is
>> added
>> +# directly in $(+link), $(+link-pie) above, so that -Wl,-rpath-link
>
> Suggest:
> # directly in $(+link) and $(+link-pie) (above), so that -Wl,-rpath-link

I think the additional parenthesis make it actually more confusing. 8-/

>> +# comes before the expansion of LDLIBS-* and affects libraries added
>> +# there.  For shared objects, -Wl,-rpath-link is added via
>> +# $(build-shlib-helper) and $(build-module-helper) in Makerules (also
>> +# before the expansion of LDLIBS-* variables).
>
> OK.
>
>> +
>> +# Test use -Wl,-rpath instead of -Wl,-rpath-link for
>
> s/Test/Tests/g

Thanks,
Florian