This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] malloc: make malloc fail with requests larger than PTRDIFF_MAX (BZ#23741)
On 18/04/2019 09:40, Joseph Myers wrote:
> On Thu, 18 Apr 2019, Adhemerval Zanella wrote:
>
>> What about the updates commit message and ChangeLog:
>>
>> --
>> malloc: make malloc fail with requests larger than PTRDIFF_MAX (BZ#23741)
>>
>> As discussed previously on libc-alpha [1], this patch follows up the idea
>> and add both the __attribute_alloc_size__ on malloc functions (malloc,
>> calloc, realloc, reallocarray, valloc, pvalloc, memaling, and
>
> s/memaling/memalign/
Ack.
>
>> posix_memalign) and limit maximum requested allocation size to up
>> PTRDIFF_MAX (taking into consideration internal padding and alignment).
>
> I think it's confusing to first say here that the attribute is being added
> to posix_memalign, and then say later that it's not.
>
Indeed, I removed posix_memalign from first paragraph.