This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/28] powerpc: Use generic fabs{f} implementations



On 15/04/2019 18:32, Tulio Magno Quites Machado Filho wrote:
> "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:
> 
>> The code generated by these functions is as follows (on powerpc64le):
>>
>> Before the patch:
>> 000000000004dac0 <fabs>:
>>    4dac0:       0e 00 4c 3c     addis   r2,r12,14
>>    4dac4:       40 9b 42 38     addi    r2,r2,-25792
>>    4dac8:       10 0a 20 fc     fabs    f1,f1
>>    4dacc:       20 00 80 4e     blr
>>
>> After the patch:
>> 000000000004dac0 <fabs>:
>>    4dac0:       10 0a 20 fc     fabs    f1,f1
>>    4dac4:       20 00 80 4e     blr
> 
> This is showing that __fabs could have been using ENTRY_TOCLESS instead of
> ENTRY. ;-)
> 

And another point try use C implementation where possible (since it
abstracts that kind of possible ABI issues) ;)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]