This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nss_dns: Enforce QDCOUNT == 1 in getnetby* implementation
- From: DJ Delorie <dj at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 08 Apr 2019 13:40:13 -0400
- Subject: Re: [PATCH] nss_dns: Enforce QDCOUNT == 1 in getnetby* implementation
The patch looked OK to me other than the h_errno and errno changes. If
you're saying we don't care about the error codes, or they're
undocumented for this failure case, then OK. But there should have been
at least minor acknowledgement that h_errno/errno would change and that
it was OK, in the original patch, because despite it being a corruption
case, h_errno/errno changes are still user visible.
Likewise for the other patch.