This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 0/4] Changes around calendar time [BZ #24293][BZ #22964]

From: Rafal Luzynski <digitalfreak at lingonborough dot com>
To: Carlos O'Donell <codonell at redhat dot com>, TAMUKI Shoichi <tamuki at linet dot gr dot jp>, libc-alpha at sourceware dot org
Date: Tue, 2 Apr 2019 00:48:29 +0200 (CEST)
Subject: Re: [PATCH 0/4] Changes around calendar time [BZ #24293][BZ #22964]
References: <201904010352.AA04315@tamuki.linet.gr.jp> <5790973a-22b2-f985-40db-f666be1744da@redhat.com>

Carlos,

1.04.2019 22:39 Carlos O'Donell <codonell@redhat.com> wrote:
> [...]
> I have reviewed all 4 patches.

Thank you for all your reviews.

> They are OK to commit to master if you fix the requested changes in each
> of the patches, and even then they are just cosmetic changes I'd like to
> see.
> 
> I would like to see your patches go in ASAP.

TAMUKI-san, one last remark: please use the format [PATCH v2 0/4]
or [PATCH v3 0/4] when you post a new version of the same patch set.
"git format-patch -v 3" will do it automatically for you.

> We do not need to wait for Rafal for review, between a native language
> speaker, and my review, this is sufficient for consensus.

I also confirm that I saw these patches and provided my limited feedback.
I have nothing more to add here.  I have just expressed one more minor
suggestion but even if it is rejected I am fine with these patches.

Regards,

Rafal

References:
- [PATCH 0/4] Changes around calendar time [BZ #24293][BZ #22964]
  - From: TAMUKI Shoichi
- Re: [PATCH 0/4] Changes around calendar time [BZ #24293][BZ #22964]
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]