This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] PPC64: First in the series of patches implementing POWER8 vector math.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: GT <tnggil at protonmail dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Mon, 25 Feb 2019 23:46:55 +0000
- Subject: Re: [PATCH] PPC64: First in the series of patches implementing POWER8 vector math.
- References: <nN0kG0GXbx7wYro2oE34bwvcauTJw_WuDyP-obLhVMc-zwTK071-mQXBD8hiITyOHI6WoxiwvNezhvebbsjFnNlAk8mCi5yX6NYpge4SAasemail@example.com> <alpine.DEB.firstname.lastname@example.org> <b7VIpuRTdy3ZwQBiTlgUL3a5zz5kQNT6OUuyOfyxrAhNG_1Xp8LolqtRZ1CssqxB5HAUcZ2-FYf64L8sAjgmfW4qiwng59NPWvSc8K0JQyoemail@example.com> <alpine.DEB.firstname.lastname@example.org> <UAbL38xXQWkyipMY5pn1BGdkMPb4Ywxu6YdGKP3cZ8qrKIkprNfEKS8SzbnMKSPL6zVuQHxVCExDfAmDTIJgjXD1JU4nyOc-4nYey-YXwJ8email@example.com>
On Mon, 25 Feb 2019, GT wrote:
> 1. svml_finite_alias.S deals only with log/logf, exp/expf and pow/powf.
> So does the discussion linked at the given url. At this time only the
> cos function has been implemented. Do we then still require
> libmvec_nonshared.a to be created?
The alternative would be to have some kind of conditional in
math/Makefile, where it creates the linker script for libm.so, based on
whatever logic determines whether there is libmvec_nonshared.a (i.e.
whether there are any objects that go in it). If you're adding new
architecture support for libmvec that doesn't start off with any functions
that bits/math-finite.h does anything with, you get to deal with adapting
the generic code to handle that previously unsupported case.
> 2. I find a single reference in the entire source tree where
> libmvec_nonshared.a doesn't appear in the dependency section of
> a rule. That's in math/Makefile. Does this mean libmvec_nonshared.a
> is created with 'make install'? I rather expected it would be built
The linker scripts that are only usable in a glibc installation, not in a
build context, are created at install time, yes. (So is the manual, hence
the build of the manual breaking from time to time when someone had a
broken change to the manual and didn't run "make install" in testing.)
Joseph S. Myers