This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add nss/tst-nss-files-hosts-long.root/etc/host.conf
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Patsy Franklin <patsy at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 21 Feb 2019 15:59:55 -0500
- Subject: Re: [PATCH] Add nss/tst-nss-files-hosts-long.root/etc/host.conf
- References: <CAOraFgBaG-ioCua_ZjMusOUbXwr1Y8gvUL-bG1MV-nkNp5KxNg@mail.gmail.com>
On 2/21/19 2:55 PM, Patsy Franklin wrote:
> [BZ #21915]
>
> Add /etc/host.conf file with 'multi on' to tst-nss-files-hosts-long.root.
> Ensures the entire file, and all long lines, need to be parsed for the
> test.
>
> Testing:
> Confirmed that the test passes with the current (fixed) sources
> on x86_64. Also confirmed that the test fails with a source tree that
> does not have BZ 21915 applied, again on x86_64. Testing was carried
> out on a RHEL7 system. Also used gdb to confirm that "multi on" is set.
This looks good to me.
OK for master.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 0001-nss-tst-nss-files-hosts-long-Add-host.conf-BZ-21915.patch
>
> From efe4ee85ae0b9c6afefccb353aeb54e3109d2de6 Mon Sep 17 00:00:00 2001
> From: Patsy Franklin <patsy@redhat.com>
> Date: Wed, 20 Feb 2019 17:07:19 -0500
> Subject: [PATCH] nss: tst-nss-files-hosts-long: Add host.conf [BZ #21915]
>
> Add /etc/host.conf file with 'multi on' to tst-nss-files-hosts-long.root.
> Ensures the entire file, and all long lines, need to be parsed for the
> test.
OK.
> ---
> ChangeLog | 5 +++++
> nss/tst-nss-files-hosts-long.root/etc/host.conf | 1 +
> 2 files changed, 6 insertions(+)
> create mode 100644 nss/tst-nss-files-hosts-long.root/etc/host.conf
>
> diff --git a/ChangeLog b/ChangeLog
> index 326201af9b..cae8e1c4cd 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2019-02-21 Patsy Griffin Franklin <pfrankli@redhat.com>
> +
> + [BZ #21915]
> + * nss/tst-nss-files-hosts-long.root/etc/host.conf: New file.
OK.
> +
> 2019-02-20 Martin Liska <mliska@suse.cz>
>
> * math/Makefile: Install math-vector-fortran.h.
> diff --git a/nss/tst-nss-files-hosts-long.root/etc/host.conf b/nss/tst-nss-files-hosts-long.root/etc/host.conf
> new file mode 100644
> index 0000000000..d1a59f73a9
> --- /dev/null
> +++ b/nss/tst-nss-files-hosts-long.root/etc/host.conf
> @@ -0,0 +1 @@
> +multi on
OK.
> -- 2.17.1
--
Cheers,
Carlos.