This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add new Fortran vector math header file.

On Tue, Feb 19, 2019 at 12:59 PM Joseph Myers <> wrote:
> *But* there could be potential interactions with Zack's patch
> <> to tokenize
> installed headers to check for obsolete typedefs, since that of course is
> tokenizing headers as C and this is adding a Fortran header to the
> installed headers.

Good catch, I hadn't been paying attention to this discussion.  The
proposed math-vector-fortran.h is indeed a problem for the test
program in my patch, because of the use of $, which is not part of the
C basic source character set.  (If I remember correctly, GCC allows $
in identifiers as an extension to C, but my test program is
intentionally very picky.)

My first reaction is to wonder whether math-vector-fortran.h should
have an extension other than .h.  I don't know what conventions there
are for this sort of thing in Fortran, but if it could have some other
extension then it would be easy to exclude it from this test in the
makefiles.  Another possibility is to put an Emacs-style "mode"
annotation on the first line of the file:  -*- f90 -*- which I could
make my test program recognize and skip the file.

Incidentally, this looks like a copy-and-paste error:

+!   You should have received a copy of the GNU Lesser General Public
+!   License along with the GNU C Library; if not, see
+!   <>.  */

Should that last line have a */ on it?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]