This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix SPARC64 handling of R_SPARC_H34 (bug 24231)

From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Mon, 18 Feb 2019 17:18:24 -0300

> 
> 
> On 18/02/2019 15:41, Joseph Myers wrote:
>> Building glibc with -Wextra shows a -Wimplicit-fallthrough warning for
>> SPARC64 that appears to be a real bug in glibc.  The dynamic linker
>> handling of R_SPARC_H34 falls through to that of R_SPARC_H44, which in
>> the case of this code is nonsensical (it means the value computed for
>> R_SPARC_H34 gets overwritten by one computed with the different logic
>> for R_SPARC_H44).  Thus, this patch adds the missing break there.
>> Note: I do not have a testcase to demonstrate this bug.
>> 
>> Tested with build-many-glibcs.py.
> 
> Look obvious enough to me.

Looks good here too.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]