This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix implicit-fallthrough warnings in tst-setjmp.c

From: Joseph Myers <joseph at codesourcery dot com>
To: Paul Eggert <eggert at cs dot ucla dot edu>
Cc: <libc-alpha at sourceware dot org>
Date: Thu, 14 Feb 2019 22:23:50 +0000
Subject: Re: Fix implicit-fallthrough warnings in tst-setjmp.c
References: <alpine.DEB.2.21.1902142203310.4022@digraph.polyomino.org.uk> <77f3c292-ec82-e34a-0a36-7ada932c4839@cs.ucla.edu>

On Thu, 14 Feb 2019, Paul Eggert wrote:

> On 2/14/19 2:03 PM, Joseph Myers wrote:
> > -static void
> > +static __attribute__ ((__noreturn__)) void
> 
> Shouldn't we use the more-standard _Noreturn for this sort of thing? cdefs.h
> defines _Noreturn for pre-C11 GCCs.

The attribute seems much more widely used in glibc .c files at present.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: Fix implicit-fallthrough warnings in tst-setjmp.c
  - From: Paul Eggert

References:
- Fix implicit-fallthrough warnings in tst-setjmp.c
  - From: Joseph Myers
- Re: Fix implicit-fallthrough warnings in tst-setjmp.c
  - From: Paul Eggert

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]