This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] RISC-V: Fix elfutils testsuite unwind failures.
- From: Andreas Schwab <schwab at suse dot de>
- To: Jim Wilson <jimw at sifive dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 13 Feb 2019 17:33:34 +0100
- Subject: Re: [PATCH] RISC-V: Fix elfutils testsuite unwind failures.
- References: <20190113234809.4818-1-jimw@sifive.com>
On Jan 13 2019, Jim Wilson <jimw@sifive.com> wrote:
> Unfortunately, the testcase isn't working as expected and I don't know why.
> The testcase passes even when my clone.S patch is not installed.
I don't see that here, with the current tools from openSUSE Factory.
There many be some (bad?) luck involved, since it's undefined territory.
> [BZ #24040]
> * elf/Makefile (CFLAGS-tst-unwind-main.c): Add -DUSE_PTHREADS=0.
> * elf/tst-unwind-main.c: If USE_PTHEADS, include pthread.h and error.h
> (func): New.
> (main): If USE_PTHREADS, call pthread_create to run func. Otherwise
> call func directly.
> * nptl/Makefile (tests): Add tst-unwind-thread.
> (CFLAGS-tst-unwind-thread.c): Define.
> * nptl/tst-unwind-thread.c: New file.
> * sysdeps/unix/sysv/linux/riscv/clone.S (__thread_start): Mark ra
> as undefined.
Ok.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."