This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Avoid fall-through in test-container if execlp fails
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 13 Feb 2019 09:19:38 +0100
- Subject: Re: Avoid fall-through in test-container if execlp fails
- References: <alpine.DEB.2.21.1902122304350.6435@digraph.polyomino.org.uk>
* Joseph Myers:
> diff --git a/support/test-container.c b/support/test-container.c
> index a24b24c03b..ed911e33f9 100644
> --- a/support/test-container.c
> +++ b/support/test-container.c
> @@ -361,6 +361,7 @@ recursive_remove (char *path)
> case 0:
> /* Child. */
> execlp ("rm", "rm", "-rf", path, NULL);
> + FAIL_EXIT1 ("exec rm: %m");
> default:
> /* Parent. */
> waitpid (child, &status, 0);
Looks good to me.