This is the mail archive of the
mailing list for the glibc project.
Re: Add fall-through comments
Joseph Myers wrote:
This patch adds fall-through comments in some cases where -Wextra
produces implicit-fallthrough warnings.
Thanks, I checked the files in question and these changes all look good to me.
For what it's worth, in Gnulib we use 'FALLTHROUGH;' for this sort of thing,
# if __GNUC__ < 7
# define FALLTHROUGH ((void) 0)
# define FALLTHROUGH __attribute__ ((__fallthrough__))
the idea being that this is a bit more robust than a comment.