This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add check for missing wrapper headers


On Fri, 8 Feb 2019, Florian Weimer wrote:

> diff --git a/Makefile b/Makefile
> index 1bfe7fefe1..dc5de7aa6b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -331,8 +331,13 @@ $(objpfx)check-installed-headers-cxx.out: \
>  	  "$(CXX) $(filter-out -std=%,$(CXXFLAGS)) -D_ISOMAC $(+includes)" \
>  	  $(headers) > $@; \
>  	$(evaluate-test)
> -endif
> -endif
> +endif # $(CXX)
> +
> +tests-special += $(objpfx)check-wrapper-headers.out
> +$(objpfx)check-wrapper-headers.out: scripts/check-wrapper-headers.py $(headers)
> +	$(PYTHON) $< --root=. --subdir=. $(headers) \
> +	  --generated $(common-generated) > $@; $(evaluate-test)
> +endif # $(headers)

This isn't a new issue, so not an objection to this patch, but I'd like us 
to move away from having tests in the top-level Makefile, so we can also 
eliminate the Makefile logic that only exists for top-level tests 
(instead, the top-level Makefile would just have the logic for combining 
test results from subdirectories).

That would presumably require moving the logic for installation of a few 
headers from top-level to some subdirectory such as include/ or misc/, so 
that tests of the headers a directory installs can get run naturally by 
that subdirectory Makefile and it's no longer necessary to have two copies 
of the rules for each such test.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]