This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix assertion in malloc.c:tcache_get


"Carlos O'Donell" <carlos@redhat.com> writes:
> On 2/4/19 6:36 PM, DJ Delorie wrote:
>> Joseph Myers <joseph@codesourcery.com> writes:
>>> -  assert (tcache->entries[tc_idx] > 0);
>>> +  assert (tcache->counts[tc_idx] > 0);
>> 
>> Yes please :-)
>  
> Did we backport this anywhere that needs this fix?

Amusingly, the code still kinda works correctly as long as pointers are
considered unsigned.  The assert will only trigger if the pointer is
NULL, which would have caused a segfault a few lines later anyway.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]