This is the mail archive of the
mailing list for the glibc project.
Re: [patch] Fix dlclose / exit running in parallel resulting in dtor being called twice
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>, "Carlos O'Donell" <carlos at redhat dot com>
- Date: Wed, 6 Feb 2019 07:41:28 -0800
- Subject: Re: [patch] Fix dlclose / exit running in parallel resulting in dtor being called twice
- References: <CALoOobMptbtaA-vfcyQuepxZrMzsPKPqTWMZbO=vwK9s0FoGhQ@mail.gmail.com> <email@example.com> <CALoOobOT_Up8Tja8WF=hBDfxECMi1rOwT5JQ4Yw78L_UvMNVYA@mail.gmail.com> <firstname.lastname@example.org> <email@example.com>
On Wed, Feb 6, 2019 at 7:28 AM Florian Weimer <firstname.lastname@example.org> wrote:
> > I think it may matter for dlsym, where you need to look dlerror to tell
> > if the symbol was NULL, or there was an actual error. But you would
> > have to clear dlerror *before* dlsym anyway, in case something else had
> > called dlsym without clearing the error.
> In other words, something like this.
The patch looks good to me.