This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH, alpha, v2]: Fix sysdeps/alpha/remqu.S clobbering $f3 reg
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Richard Henderson <rth at twiddle dot net>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, libc-alpha at sourceware dot org
- Date: Thu, 24 Jan 2019 23:43:34 +0530
- Subject: Re: [PATCH, alpha, v2]: Fix sysdeps/alpha/remqu.S clobbering $f3 reg
- References: <CAFULd4YPY82vzMqpyCj7ng_Q2wW+LuLr7tMn=V-kh+rK_JNZqg@mail.gmail.com> <8d7d71ad-53f4-a9ff-d292-5494827b2082@twiddle.net>
On 24/01/19 11:34 PM, Richard Henderson wrote:
> On 1/24/19 1:40 AM, Uros Bizjak wrote:
>> Attached patch fixes sysdeps/alpha/remqu.S clobbering $f3 register via
>> $y_is_neg path. There was missing restore of $f3 before the return
>> from the function.
>>
>> Without the patch, math/big testcase from Go-1.11 testsuite (that
>> includes lots of corner cases that exercise remqu) FAIL, with patched
>> function, the testcase PASSes without problems.
>>
>> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
>>
>> 2019-24-01 Uroš Bizjak <ubizjak@gmail.com>
>>
>> * sysdeps/alpha/remqu.S (__remqu): Add missing restore
>> of $f3 register on $y_is_neg path.
>
> Thanks. I've created BZ# 24130 to go with this.
> Siddhesh, ok to commit at this stage?
This is fine.
Thanks,
Siddhesh