This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: misc/check-installed-headers-c failing due to upstream kernel change
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Ben Hutchings <ben dot hutchings at codethink dot co dot uk>, Vineet Gupta <vineet dot gupta1 at synopsys dot com>, libc-alpha at sourceware dot org
- Cc: Feng Tang <feng dot tang at intel dot com>, Steven Rostedt <rostedt at goodmis dot org>, Andrew Morton <akpm at linux-foundation dot org>
- Date: Wed, 23 Jan 2019 11:51:03 -0500
- Subject: Re: misc/check-installed-headers-c failing due to upstream kernel change
- References: <4db851ae-9bb2-2159-96bf-c4b34b505bd9@synopsys.com> <1548259069.3229.308.camel@codethink.co.uk>
On 1/23/19 10:57 AM, Ben Hutchings wrote:
> On Mon, 2019-01-21 at 14:56 -0800, Vineet Gupta wrote:
>> Hi,
>>
>> It seems a recent upstream kernel change (went in 5.0-rcX) 81c9d43f9487
>> ("kernel/sysctl: add panic_print into sysctl") trips one of the glibc tests.
>>
>> FAIL: misc/check-installed-headers-c
>>
>>> :: sys/sysctl.h
>>> ::::
>>> *** Obsolete types detected:
>>> ~/install/compilers/arc-linux-gnu/sysroot/usr/include/linux /sysctl.h:
>>> KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */
>>
>> It doesn't seem to like ulong (inside a comment). I don't have enough foo to fix
>> it, but wanted to bring it to notice anyways.
>
> This additions looks like a mistake, anyway - Linux's binary sysctl
> interface is only there for ancient compatibility and no new sysctls
> should be added to this enumeration.
Just to be clear, this glibc test failure is a false positive [1], and
we're working to correct this [2]. However, if this is also not needed on
the kernel side, then that's also OK with us :-)
--
Cheers,
Carlos.
[1] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00413.html
[2] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00513.html