This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v9 0/2] strftime: Improve the width of alternative representation for year [BZ #23758][BZ #24096]


22.01.2019 02:44 TAMUKI Shoichi <tamuki@linet.gr.jp> wrote:
> 
> Hello,
> 
> This is the new set of patches.  I have split the patch into 2 parts.
> 
> Note, Patch 1 is same as v8.
> 
> Changes include:
> 
> Patch 1: strftime: Set the default width of "%Ey" to 2
> Patch 2: strftime: Pass the additional flags from "%EY" to "%Ey"

Both patches look good to me.  Especially the first one since it
is the same as the previous version which I already said was OK,
and since this patch actually changes only one line of the code
and other lines change just the documentation.

My suggestion: please wait a while to let the other maintainers
express their final opinion and push them to the repository if
nobody replies or if anybody asks you to push immediately.

I think that waiting 24 hours from now or maximum 48 hours is enough.

Please remember to update the ChangeLog when pushing and to close
the bug reports.  And then please port these changes to Gnulib.

Again thank you for working on this.

Regards,

Rafal


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]