This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v8 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #24096]
- From: TAMUKI Shoichi <tamuki at linet dot gr dot jp>
- To: Rafal Luzynski <digitalfreak at lingonborough dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 22 Jan 2019 10:40:24 +0900
- Subject: Re: [PATCH v8 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #24096]
- References: <428627917.497184.1548091409555@poczta.nazwa.pl>
Hello Rafal,
From: Rafal Luzynski <digitalfreak@lingonborough.com>
Subject: Re: [PATCH v8 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #24096]
Date: Mon, 21 Jan 2019 18:23:29 +0100 (CET)
> > +If the @code{E} modifier is specified (@code{%EC}), instead produces
> > +the name of the period for the year (e.g. an era name) in the locale's
> > +alternative calendar.
> > +
>
> "e.g." should be "e.g.@:". It is important to use "@:" to mark that this
> dot is not the end of a sentence and thus control the space width.
OK, I will fix this in the next patch.
> > + int yr_spec = 0; /* Override padding for "%Ey". */
>
> I think that you don't need this variable now.
>
> > - return __strftime_internal (s, maxsize, format, tp, &tzset_called
> > + return __strftime_internal (s, maxsize, format, tp, yr_spec,
>
> Consequently, you can pass 0 instead of yr_spec here.
Exactly you are right. I will fix this in the next patch.
> I don't quote the rest of the code because I believe it is OK.
>
> Please verify if my suggestions are correct, I am unable to test now.
The test is OK. I attach the result to this mail.
Regards,
TAMUKI Shoichi