This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH COMMITTED] Switch IDNA implementation to libidn2 [BZ #19728] [BZ #19729] [BZ #22247]
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 21 Jan 2019 10:30:16 +0100
- Subject: Re: [PATCH COMMITTED] Switch IDNA implementation to libidn2 [BZ #19728] [BZ #19729] [BZ #22247]
- References: <20180523132942.17F52402B59C6@oldenburg.str.redhat.com> <mvmfttmcr5t.fsf@suse.de>
* Andreas Schwab:
> On Mai 23 2018, fweimer@redhat.com (Florian Weimer) wrote:
>
>> diff --git a/inet/idna.c b/inet/idna.c
>> new file mode 100644
>> index 0000000000..c561bf2e9e
>> --- /dev/null
>> +++ b/inet/idna.c
>> @@ -0,0 +1,182 @@
>> +/* IDNA functions, forwarding to implementations in libidn2.
>> + Copyright (C) 2018 Free Software Foundation, Inc.
>> + This file is part of the GNU C Library.
>> +
>> + The GNU C Library is free software; you can redistribute it and/or
>> + modify it under the terms of the GNU Lesser General Public
>> + License as published by the Free Software Foundation; either
>> + version 2.1 of the License, or (at your option) any later version.
>> +
>> + The GNU C Library is distributed in the hope that it will be useful,
>> + but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>> + Lesser General Public License for more details.
>> +
>> + You should have received a copy of the GNU Lesser General Public
>> + License along with the GNU C Library; if not, see
>> + <http://www.gnu.org/licenses/>. */
>> +
>> +#include <allocate_once.h>
>> +#include <dlfcn.h>
>> +#include <inet/net-internal.h>
>> +#include <netdb.h>
>> +#include <stdbool.h>
>> +
>> +/* Use the soname and version to locate libidn2, to ensure a
>> + compatible ABI. */
>> +#define LIBIDN2_SONAME "libidn2.so.0"
>
> That library no longer exists.
See <https://gitlab.com/libidn/libidn2/issues/63>. The soname bump
appears unnecessary. Let's wait a few days and see how libidn2 upstream
reacts.
Thanks,
Florian