This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Tests for minimal signal handler functionality in MINSIGSTKSZ space.



On 16/01/2019 01:40, Siddhesh Poyarekar wrote:
> On 16/01/19 2:45 AM, Carlos O'Donell wrote:
>> Thank you for doing this.
>>
>> OK for master with comment addition in implementation.
>>
>> You need Siddhesh to approve the extra tests.
>>
> 
> OK to add these tests to master.
> 
> Siddhesh

We need something like below for Hurd:

diff --git a/support/xsigstack.c b/support/xsigstack.c
index cebfa19..5656e84 100644
--- a/support/xsigstack.c
+++ b/support/xsigstack.c
@@ -63,6 +63,12 @@ xalloc_sigstack (size_t size)
   /* Use MAP_NORESERVE so that RAM will not be wasted on the guard
      bands; touch all the pages of the actual stack before returning,
      so we know they are allocated.  */
+#ifndef MAP_NORESERVE
+# define MAP_NORESERVE 0
+#endif
+#ifndef MAP_STACK
+# define MAP_STACK 0
+#endif
   desc->alloc_base = xmmap (0,
                             desc->alloc_size,
                             PROT_READ|PROT_WRITE,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]