This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: Revert fastbins to old-style atomics
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Wed, 16 Jan 2019 10:18:54 -0500
- Subject: Re: [PATCH] malloc: Revert fastbins to old-style atomics
- References: <87d0owzrcf.fsf@oldenburg2.str.redhat.com>
On 1/16/19 8:04 AM, Florian Weimer wrote:
> Commit 6923f6db1e688dedcf3a6556da76e0bf24a41872 ("malloc: Use current
> (C11-style) atomics for fastbin access") caused a substantial
> performance regression on POWER and Aarch64, and the old atomics,
> while hard to prove correct, seem to work in practice.
Why is it slow?
What do the benchmarks say?
What does profiling show to be the slow instruction?
How is the instruction sequence different from before that causes the problem?
--
Cheers,
Carlos.