This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: fix tst-ucontext-ppc64-vscr test for POWER 5/6


Rogerio Alves <rcardoso@linux.ibm.com> writes:

> Subject: [PATCH] powerpc: fix tst-ucontext-ppc64-vscr test for POWER 5/6.
>
> An error: impossible register constraint in 'asm' was raised on POWER 5 and
> 6 due a __vector __int128_t being used as operands without passing the

due to...

> option -msvx to gcc. However, the test doesn't need to use a __int128_t a

 2 spaces ------------^

> unsigned int should work.

The last sentence is confusing and I replace it with:

    This patch replaces "__vector __int128_t" with "__vector unsigned int"
    which requires only -maltivec, available since POWER ISA 2.03, and which
    is already passed to the compiler.

> 2019-01-14  Rogerio A. Cardoso  <rcardoso@linux.ibm.com>
>
> 	* sysdeps/powerpc/powerpc64/tst-ucontext-ppc64-vscr.c: Changed __vector

Missing the entity name -------------------------------------^

> __int128_t to vector unsigned int.

  ^--- Missing tab.

I modified this ChangeLog entry to:

	* sysdeps/powerpc/powerpc64/tst-ucontext-ppc64-vscr.c:
	(do_test): Changed __vector __int128_t to vector unsigned int.

Modified and pushed as 56054664ccf837fa325692c0359baa62c64491a1.

Thanks!

-- 
Tulio Magno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]