This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] [Makefile] Exit if provided an incorrect argument
- From: Matthew Malcomson <Matthew dot Malcomson at arm dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Tue, 15 Jan 2019 10:33:16 +0000
- Subject: Re: [Patch] [Makefile] Exit if provided an incorrect argument
- References: <VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10@VI1PR0801MB2014.eurprd08.prod.outlook.com> <875zuq6xv9.fsf@oldenburg2.str.redhat.com>
On 15/01/19 10:03, Florian Weimer wrote:
> * Matthew Malcomson:
>
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
>> ;;
>> --*)
>> usage
>> + exit 1
>> ;;
>> *)
>> break
> I think you should add the exit to the usage function.
>
> Thanks,
> Florian
Makes sense -- thanks!
Fixed patch attached.
ChangeLog:
2019-01-15 Matthew Malcomson <matthew.malcomson@arm.com>
* Makefile (testrun.sh): Exit if provided incorrect arg.
--- Patch Inlined for ease of reply ----
diff --git a/Makefile b/Makefile
index b4703e4..9d76d86 100644
--- a/Makefile
+++ b/Makefile
@@ -137,6 +137,7 @@ GCONV_PATH="$${builddir}/iconvdata"
usage () {
echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1
echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1
+ exit 1
}
toolname=default
diff --git a/Makefile b/Makefile
index b4703e4..9d76d86 100644
--- a/Makefile
+++ b/Makefile
@@ -137,6 +137,7 @@ GCONV_PATH="$${builddir}/iconvdata"
usage () {
echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1
echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1
+ exit 1
}
toolname=default