This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] [Makefile] Exit if provided an incorrect argument
- From: Matthew Malcomson <Matthew dot Malcomson at arm dot com>
- To: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Tue, 15 Jan 2019 10:00:53 +0000
- Subject: Re: [Patch] [Makefile] Exit if provided an incorrect argument
- References: <VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10@VI1PR0801MB2014.eurprd08.prod.outlook.com>
ping
On 14/12/18 14:26, Matthew Malcomson wrote:
> At the moment the ./testrun.sh file generated for testing a new glibc
> doesn't handle incorrect arguments well.
> It prints the usage of the script in an infinite loop.
>
> This patch stops the infinite loop by exiting the program.
>
> Tested by manually running the script after building.
> I don't have commit rights, so if OK could someone commit this for me.
> OK for master?
>
> ChangeLog:
>
> 2018-11-29 Matthew Malcomson <matthew.malcomson@arm.com>
>
> * Makefile (testrun.sh): Exit if provided incorrect arg.
>
>
> diff --git a/Makefile b/Makefile
> index b4703e48fec93075cd5e3ddd83469705d2fee8f8..1e1866be3da1ba4520911eb27016544de419161b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
> ;;
> --*)
> usage
> + exit 1
> ;;
> *)
> break
>