This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v6] strftime: Consequently use the "L_" macro with character literals
11.01.2019 14:56 Florian Weimer <fweimer@redhat.com> wrote:
>
> * Andreas Schwab:
>
> > On Jan 11 2019, Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
> >
> >> Please add "." (a dot, a full stop) at the end of the first line
> >> of the commit message which is also the subject of this email.
> >
> > A subject line should not end with a period.
>
> We don't have a firm rule here. [...]
I don't remember where I saw that rule. All I can find now is that
examples in the Contribution Checklist [1] do end with a period.
I will update here if I find anything more.
I agree that a subject line should not end with a period but no
matter how weird it looks I always add it for the sake of the commit
message format.
Regards,
Rafal
[1]
https://sourceware.org/glibc/wiki/Contribution%20checklist#Contribution_Email_Subject_Line