This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] power: Fix VSCR position on ucontext
- From: Tulio Magno Quites Machado Filho <tuliom at ascii dot art dot br>
- To: Rogerio Alves <rcardoso at linux dot ibm dot com>, "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- Cc: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Cc:
- Date: Thu, 10 Jan 2019 17:52:07 -0200
- Subject: Re: [PATCH] power: Fix VSCR position on ucontext
- References: <8a619ad1-b7f2-04f8-f9a7-0a19cbf98f4c@linux.ibm.com> <87lg5va6a6.fsf@oldenburg.str.redhat.com> <20181116111825.43b60283@tereshkova.br.ibm.com> <5e1d1cab-7c91-90f8-82d2-fd38f8676f30@linux.ibm.com> <20181207162959.5e5d8933@tereshkova> <20181210153658.32b0e266@tereshkova> <87tvjl8bx7.fsf@linux.ibm.com> <ecf16bc6-c756-1147-4a72-03efbdd64ef4@linux.ibm.com>
Rogerio Alves <rcardoso@linux.ibm.com> writes:
> Subject: [PATCH v4] powerpc: Fix VSCR position in ucontext.
>
> This patch fix VSCR position on ucontext. VSCR was read in the wrong
> position on ucontext structure because it was ignoring the machine
> endianess.
>
> 2018-11-05 Rogerio A. Cardoso <rcardoso@linux.ibm.com>
>
> * sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h
> (struct _libc_vscr, vscr_t): Added ifdef to fix read of VSCR.
> * sysdeps/powerpc/powerpc64/Makefile: Add tst-ucontext-ppc64-vscr.c
> to test list.
> * sysdeps/powerpc/powerpc64/tst-ucontext-ppc64-vscr.c: New test file.
> /* This test is supported only on POWER 5 or higher. */
> +#define PPC_CPU_SUPPORTED (PPC_FEATURE_POWER5 | PPC_FEATURE_POWER5_PLUS | \
> + PPC_FEATURE_ARCH_2_05 | PPC_FEATURE_ARCH_2_06 | \
The GNU Coding Standard requires to replace 8 spaces with a tab.
Fixed locally. ;-)
> + ".machine \"power7\";\n"
s/power7/power5/
Fixed.
The patch looks good to me except for one thing: this is fixing a bug visible
to the user, so we also need a bug report for this.
Could you open the bug and send me the number? I can incorporate it here
before pushing the patch.
Thanks!
--
Tulio Magno