This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] ld.so: command argument "--preload"
- From: Florian Weimer <fweimer at redhat dot com>
- To: David Newall <glibc at davidnewall dot com>
- Cc: Carlos O'Donell <carlos at redhat dot com>, libc-alpha at sourceware dot org
- Date: Wed, 09 Jan 2019 16:26:04 +0100
- Subject: Re: [PATCH] ld.so: command argument "--preload"
- References: <322fb70a-9c0e-100b-4366-dfa7e5134aa5@davidnewall.com> <265bec63-9875-7268-2199-c7e133b2298e@davidnewall.com> <874ldb7gxp.fsf@oldenburg.str.redhat.com> <5f79f366-d687-583f-940c-36c169bd34a9@davidnewall.com> <cfd15aee-c960-0599-b053-d36ce40c9707@redhat.com> <fe18f63f-0b38-361b-17a0-64820e013bc5@davidnewall.com> <87sh0eqssf.fsf@oldenburg.str.redhat.com> <8816b7fc-d798-42ee-de51-d1de56e6887c@davidnewall.com> <87zhuljiev.fsf@oldenburg.str.redhat.com> <43265e8e-956a-f895-6c04-8cd6898a8c97@davidnewall.com> <877ehphv2a.fsf@oldenburg.str.redhat.com> <2e1f89d3-9718-50ca-328c-b4b82b1974d4@davidnewall.com> <8736sdhtim.fsf@oldenburg.str.redhat.com> <e6c688f3-535a-265b-f516-69d91379a495@davidnewall.com> <be388b70-df15-75ef-152d-90c0bd2099c6@davidnewall.com> <87va57dekq.fsf@oldenburg.str.redhat.com> <b4926cb8-cef2-ef29-8407-d3fc3dc225a5@davidnewall.com>
* David Newall:
> +${test_wrapper} $rtld --library-path $library_path --preload $preload $test_program 2>&1 && rc=0 || rc=$?
I would suggest to use "" around shell variables where applicable, and
wrap this long line (using \).
There are also a few stylistic issues we need to fix: Two whitespace
problems (”. */” at end of comments, space before parenthesis in
function call, not after it). The copyright statement for the new file
needs a bit polishing.
But the change as such looks okay to me. We can commit this for your
after 2.30 development opens in Feburary. I'll supply a new NEWS entry
and a ChangeLog entry, too.
Thanks,
Florian