This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] en_US: define date_fmt (bug 24046)
On 2019-01-05 15:24, Rafal Luzynski wrote:
> 5.10.2019 01:39 Aurelien Jarno <aurelien@aurel32.net> wrote:
> >
> > On 2019-01-05 01:19, Rafal Luzynski wrote:
> [...]
> > > What do you
> > > think about my suggestion to use "%r" instead of "%I:%M:%S %p"?
> >
> > That's more a technical question. I used this form, because the C locale
> > expands the conversion specifications. But if we can technically use
> > "%r", it's fine for me, I can update the patch. Can we even use "%c"
> > directly?
>
> I think I have not seen "%c" in any locale but I'm not aware of any
> technical limitation. Does it make any difference, like a performance
> drop? Probably yes and probably negligible. Please test thoroughly
I have tried using "%c" and it works fine on my system. That said, given
no other locales use this, I am a bit reluctant to do that change now.
> and please post here before committing so other people will be able
> to test as well.
I have just posted an updated version of the patch, which sticks to
"%a %d %b %Y %r %Z" and has and update comment. I have tested it here
and I have also checked it doesn't cause any regression in the
testsuite, as the en_US locale is used in a few tests.
Regards,
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net