Re: [PATCH] Deprecate 32-bit off_t support

[Florian Weimer <fweimer at redhat dot com>]

* Siddhesh Poyarekar:

> On 04/01/19 6:15 PM, Siddhesh Poyarekar wrote:
>> On 04/01/19 6:09 PM, Florian Weimer wrote:
>>> diff --git a/NEWS b/NEWS
>>> index cc20102fda..2f601c6217 100644
>>> --- a/NEWS
>>> +++ b/NEWS
>>> @@ -85,6 +85,15 @@ Deprecated and removed features, and other
>>> changes affecting compatibility:
>>>     as all functions that call vscanf, vfscanf, or vsscanf are
>>> annotated with
>>>     __attribute__ ((format (scanf, ...))).
>>> +* A future release of glibc will use a 64-bit off_t type on all
>>
>> Wouldn't it be clearer to fix the 'future release' to a specific
>> timeline, say, 2.31 (to give a year+ to change offending code) so
>> that this doesn't sound like a vague threat and there's actually a
>> time bound for people to work with?

2.31 sounds okay to me.  2.30 would work for me as well.  What do others
think?

> Oh, and a warning under #if _FILE_OFFSET_BITS == 32 that warns about
> the deprecation?

Due to -Werror, that alone would be rather disruptive.  It's too late to
add this for 2.29, too.

Thanks,
Florian