This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4] Y2038: add function __localtime64
- From: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- To: "Albert ARIBAUD (3ADEV)" <albert dot aribaud at 3adev dot fr>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Fri, 4 Jan 2019 10:28:07 +0000
- Subject: Re: [PATCH v4] Y2038: add function __localtime64
- References: <20181212221226.29207-1-albert.aribaud@3adev.fr> <20181213074441.17138-1-albert.aribaud@3adev.fr>
On 13/12/2018 07:44, Albert ARIBAUD (3ADEV) wrote:
> Tested with 'make check' on x86_64-linux-gnu and i686-linux.gnu.
>
> * include/time.h
> (__localtime64): Add.
> * manual/maint.texi: Document Y2038 symbol handling.
> * time/localtime.c
> (__localtime64): Add.
> [__TIMERSIZE != 64] (__localtime): Turn into a wrapper.
> ---
> v4: Add paragraph about macros to manual section as suggested by
> Joseph Myers
> v3: Rewrite manual section as suggested by Joseph Myers
> Revert blank line removals
> Ensure periods are followed with two spaces
> Fix typos
> Remove () after function names
> v2: Fix 'Y2038' => @dfn{Y2038} in manual/maint.texi
>
> include/time.h | 8 +++
> manual/maint.texi | 125 ++++++++++++++++++++++++++++++++++++++++++++++
> time/localtime.c | 16 +++++-
> 3 files changed, 148 insertions(+), 1 deletion(-)
...
> +The 64-bit-time implementation of @code{localtime} is written as follows
> +and is compiled for both dual-time and single-time configuration classes.
> +
> +@smallexample
> +struct tm *
> +__localtime64 (const __time64_t *t)
> +@lbracechar{}
> + return __tz_convert (*t, 1, &_tmbuf);
> +@rbracechar{}
> +libc_hidden_def (__localtime64)
> +@end smallexample
install.texi requires GNU @code{texinfo} 4.7 or later
but this fails with texinfo 4.13:
/S/glibc/manual//maint.texi:288: Unknown command `lbracechar'.
/S/glibc/manual//maint.texi:288: Misplaced {.
/S/glibc/manual//maint.texi:288: Misplaced }.
/S/glibc/manual//maint.texi:290: Unknown command `rbracechar'.
/S/glibc/manual//maint.texi:290: Misplaced {.
/S/glibc/manual//maint.texi:290: Misplaced }.
/S/glibc/manual//maint.texi:302: Unknown command `lbracechar'.
/S/glibc/manual//maint.texi:302: Misplaced {.
/S/glibc/manual//maint.texi:302: Misplaced }.
/S/glibc/manual//maint.texi:305: Unknown command `rbracechar'.
/S/glibc/manual//maint.texi:305: Misplaced {.
/S/glibc/manual//maint.texi:305: Misplaced }.
makeinfo: Removing output file `/B/glibc/manual/libc.info' due to errors; use --force to preserve.
make[2]: *** [Makefile:142: /B/glibc/manual/libc.info] Error 1