This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] riscv: Use __has_include__ to include <asm/syscalls.h> [BZ #24022]


On Mon, Dec 31, 2018 at 10:25 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>
> * H. J. Lu:
>
> > On Mon, Dec 31, 2018 at 9:36 AM Florian Weimer <fw@deneb.enyo.de> wrote:
> >>
> >> * H. J. Lu:
> >>
> >> > +#if __has_include__ (<asm/syscalls.h>)
> >>
> >> Isn't __has_include (no trailing __) the more canonical name?
> >> I think that's what's in C++17.
> >
> > I think __has_include__ is OK for glibc internal source.
>
> Both are accepted by the compiler.  But I want to reduce cognitive
> load for the reader, and avoid use unportable constructs when
> prefectly portable ones exist.

Fine with me.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]