Re: [PATCH 1/5] Y2038: add function __localtime64_r

[Albert ARIBAUD <albert dot aribaud at 3adev dot fr>]

Hi Joseph,

On Mon, 17 Dec 2018 22:17:22 +0000, Joseph Myers
<joseph@codesourcery.com> wrote :

> On Mon, 17 Dec 2018, Albert ARIBAUD (3ADEV) wrote:
> 
> > +/* Provide a 32-bit variant if needed */  
> 
> Throughout this series, please make sure comments end with ".  " (full 
> stop, two spaces) before end of comment.  You have the same mistake in 
> other patches in this series.

Fixed. Is there a script that I could run on my local repo that
would check for these and which I could install as a git pre-commit
hook?

> You're declaring __localtime64_r with attribute_hidden.  Although not 
> strictly wrong at this stage, since the point is eventually to export it 
> from libc it would be better to declare it without attribute_hidden, and 
> instead use libc_hidden_proto / libc_hidden_def (those are needed because 
> of the call from __localtime_r).  Otherwise you'll need to remove the 
> attribute_hidden, and add the libc_hidden_*, in a later patch that exports 
> or prepares to export the functions.

Fixed for __localtime64_r, __gmtime64 and __gmtime64_r.

ctime and ctime_r are not called from within glibc at all and have no
libc_hidden_proto/libc_hidden_def, so I did not add any to __ctime64
and __ctime64_r.

Thanks for your feedback!

Cordialement,
Albert ARIBAUD
3ADEV