This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] tzset did not catch changes to localtime [BZ #21060 ]
- From: Andreas Schwab <schwab at suse dot de>
- To: <ma dot jiang at zte dot com dot cn>
- Cc: <carlos at redhat dot com>, <libc-alpha at sourceware dot org>
- Date: Mon, 17 Dec 2018 10:39:57 +0100
- Subject: Re: [PATCH] tzset did not catch changes to localtime [BZ #21060 ]
- References: <201812171717582865803@zte.com.cn>
On Dez 17 2018, <ma.jiang@zte.com.cn> wrote:
> + /* Check whether the tz value changed since the last run. */
> + int tz_changed = old_tz ? strcmp (tz, old_tz) : 1;
This should be written as old_tz == NULL || strcmp (tz, old_tz) != 0,
and tz_changed should be bool.
> + if ((old_tz == NULL)
> + || (old_tz != NULL && tz_changed))
This is the same as tz_changed.
> + {
> + /* Save the value of `tz'. */
> + free (old_tz);
> + old_tz = __strdup (tz);
> + }
Wrong indentation.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."