This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Reindent nptl/pthread_rwlock_common.c


* Andreas Schwab:

> @@ -338,8 +338,9 @@ __pthread_rwlock_rdlock_full (pthread_rwlock_t *rwlock,
>       expected value for future operations.  Acquire MO so we synchronize with
>       prior writers as well as the last reader of the previous read phase (see
>       below).  */
> -  r = atomic_fetch_add_acquire (&rwlock->__data.__readers,
> -      (1 << PTHREAD_RWLOCK_READER_SHIFT)) + (1 << PTHREAD_RWLOCK_READER_SHIFT);
> +  r = (atomic_fetch_add_acquire (&rwlock->__data.__readers,
> +				 (1 << PTHREAD_RWLOCK_READER_SHIFT))
> +       + (1 << PTHREAD_RWLOCK_READER_SHIFT));

Aren't some of these parentheses you are removing recommended for
getting correct indentation from Emacs?

(I do not particularly like them and think the identation without them
is just as fine, but others may disagree.)

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]