This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86/CET: Renumber ARCH_CET_LEGACY_BITMAP to 0x3006
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 11 Dec 2018 12:33:10 +0100
- Subject: Re: [PATCH] x86/CET: Renumber ARCH_CET_LEGACY_BITMAP to 0x3006
- References: <20181120142214.20783-1-hjl.tools@gmail.com> <875zwrenrs.fsf@oldenburg.str.redhat.com> <CAMe9rOoNf7kZTNq=a59W2g9M6Fb7sJpM5jO6JpNV1800F7_Kug@mail.gmail.com> <87sgzu2fw1.fsf@oldenburg.str.redhat.com> <CAMe9rOry=G7tL5bFPa1ZAy2oac88pHRNbiW9bdRaMrypD-a8HA@mail.gmail.com> <87y39jubim.fsf@oldenburg.str.redhat.com> <CAMe9rOq+sngvg2g4P4m5z8zA_mNuiparJJTObjKBjm8BN37OtQ@mail.gmail.com>
* H. J. Lu:
> On Fri, Nov 23, 2018 at 6:14 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * H. J. Lu:
>>
>> > + _dl_exception_create_format
>> > + (&exception, DSO_FILENAME (l->l_name),
>> > + "mmap size 0x%Zx failed", legacy_bitmap_size);
>> > + _dl_signal_cexception
>>
>> I think you should mark the string as translateable and say that it's
>> for the legacy bitmap.
>
> Like this?
Yes, but please wait with committing until the kernel part has been
merged into mainline at least.
Thanks,
Florian