This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add getcpu

From: Tulio Magno Quites Machado Filho <tuliom at ascii dot art dot br>
To: "H.J. Lu" <hjl dot tools at gmail dot com>, Florian Weimer <fweimer at redhat dot com>
Cc: Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, Andreas Schwab <schwab at suse dot de>
Cc:
Date: Fri, 07 Dec 2018 10:50:53 -0200
Subject: Re: [PATCH] Add getcpu
References: <CAMe9rOpcy16tREX8Gb0qYPXXc__Vzykj2c=M20aBOn4p0gUBGw@mail.gmail.com> <a8efebb5-fa4b-d124-a635-c91f5d05e92f@redhat.com> <CAMe9rOo8Pq24S4iGt5FEUxgwq0+ywy4dsCqdxD0tioSPGc8NJg@mail.gmail.com> <877egng68l.fsf@oldenburg2.str.redhat.com> <CAMe9rOpRm1fSa4v91C1Ec8gH4J2N48FcDP-sdfZKrEiOFkmYoA@mail.gmail.com> <87va47eoge.fsf@oldenburg2.str.redhat.com> <CAMe9rOo7i_-keOooa0D+P_wzatVCdKkTRiFiJ-cxpnvi+eApuQ@mail.gmail.com> <CAMe9rOr=A2ViztKHJYuDzEcdq5ukg2=VsZU=CHWu=wnh7nV_sQ@mail.gmail.com>

"H.J. Lu" <hjl.tools@gmail.com> writes:

> 	* NEWS: Mention getcpu.
> 	* include/sched.h (__getcpu): New libc_hidden_proto.
> 	* sysdeps/unix/sysv/linux/Makefile (sysdep_routines): Add getcpu.
> 	* sysdeps/unix/sysv/linux/Versions (GLIBC_2.29): Add getcpu.
> 	* sysdeps/unix/sysv/linux/aarch64/libc.abilist: Add getcpu.
> 	* sysdeps/unix/sysv/linux/alpha/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/arm/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/hppa/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/ia64/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/microblaze/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist:
> 	Likewise.
> 	* sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/nios2/libc.abilist: Likewise.
> 	* sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist:
> 	Likewise.
> 	* sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist:
> 	Likewise.
> 	* sysdeps/unix/sysv/linux/powerpc/powerpc64/libc.abilist:
> 	Likewise.

I noticed the powerpc64le abilist file is missing in the ChangeLog.

>  NEWS                                          |  3 ++
>  include/sched.h                               |  2 +
>  sysdeps/unix/sysv/linux/Makefile              |  2 +-
>  sysdeps/unix/sysv/linux/Versions              |  3 ++
>  sysdeps/unix/sysv/linux/aarch64/libc.abilist  |  1 +
>  sysdeps/unix/sysv/linux/alpha/libc.abilist    |  1 +
>  sysdeps/unix/sysv/linux/arm/libc.abilist      |  1 +
>  sysdeps/unix/sysv/linux/bits/sched.h          |  3 ++
>  sysdeps/unix/sysv/linux/getcpu.c              | 38 +++++++++++++++++++
>  sysdeps/unix/sysv/linux/hppa/libc.abilist     |  1 +
>  sysdeps/unix/sysv/linux/i386/libc.abilist     |  1 +
>  sysdeps/unix/sysv/linux/ia64/libc.abilist     |  1 +
>  .../sysv/linux/m68k/coldfire/libc.abilist     |  1 +
>  .../unix/sysv/linux/m68k/m680x0/libc.abilist  |  1 +
>  .../unix/sysv/linux/microblaze/libc.abilist   |  1 +
>  .../sysv/linux/mips/mips32/fpu/libc.abilist   |  1 +
>  .../sysv/linux/mips/mips32/nofpu/libc.abilist |  1 +
>  .../sysv/linux/mips/mips64/n32/libc.abilist   |  1 +
>  .../sysv/linux/mips/mips64/n64/libc.abilist   |  1 +
>  sysdeps/unix/sysv/linux/nios2/libc.abilist    |  1 +
>  .../linux/powerpc/powerpc32/fpu/libc.abilist  |  1 +
>  .../powerpc/powerpc32/nofpu/libc.abilist      |  1 +
>  .../linux/powerpc/powerpc64/libc-le.abilist   |  1 +

While you're making the correct changes.  So, just a ChangeLog entry missing.

This patch will conflict with an earlier patch from Andreas Schwab:
https://sourceware.org/ml/libc-alpha/2018-11/msg00752.html

-- 
Tulio Magno

Follow-Ups:
- Re: [PATCH] Add getcpu
  - From: H.J. Lu

References:
- RFC: Add getcpu wrapper
  - From: H.J. Lu
- Re: RFC: Add getcpu wrapper
  - From: Carlos O'Donell
- [PATCH] Add getcpu
  - From: H.J. Lu
- Re: [PATCH] Add getcpu
  - From: Florian Weimer
- Re: [PATCH] Add getcpu
  - From: H.J. Lu
- Re: [PATCH] Add getcpu
  - From: Florian Weimer
- Re: [PATCH] Add getcpu
  - From: H.J. Lu
- Re: [PATCH] Add getcpu
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]