This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] posix: New function posix_spawn_file_actions_addfchdir_np [BZ #17405]


* Adhemerval Zanella:

> On 30/11/2018 11:44, Florian Weimer wrote:
>> This will need porting to Hurd (currently it results in a -Werror
>> failure); it should be easier than the last time.  Since the
>> cross-buildbot is broken right now anyway, I intend to commit this once
>> the generic/Linux portion is approved.
>
> I think it is worth to mention on commit log there is an open POSIX
> enhancement request [1] that aims to add similar functionality.
>
> [1] http://austingroupbugs.net/view.php?id=1208

Something like this?

Along with posix_spawn_file_actions_addchdir,
posix_spawn_file_actions_addfchdir is the subject of a change proposal
for POSIX: <http://austingroupbugs.net/view.php?id=1208>

> As side note, should posix_spawn_file_actions_addchdir_np use __restrict for
> argument definitions? It also seems __restrict usage is also missing in some
> places for spawn.h.

There are other attributtes missing as well (nonnull comes to my mind).
I think we should add them in one go.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]