This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] support: Implement <support/descriptors.h> to track file descriptors

27.11.2018 18:25 Florian Weimer <> wrote:
> 2018-11-27  Florian Weimer  <>
> 	* support/descriptors.h: New file.
> 	* support/check.h (support_record_failure_is_failed): Declare.


> 	* support/support_descriptors.c: Likewise.
> 	* support/tst-support_descriptors.c: Likewise.

These "Likewise" look like "Declare" but I'm pretty sure you meant
"New file".  Please use "New file" instead of the first "Likewise"
or maybe better just reorder the lines so that "Likewise" follows
"New file".  I think it is reasonable to put "check.h" in the first
line, this sorts the entries alphabetically and resolves the problem.

> 	* support/support_record_faile.c


> 	(support_record_failure_is_failed): New function.
> [...]
> +static int
> +do_test (void)
> +{
> +  puts ("info: initial descriptor set");
> +  {
> +    struct support_descriptors *descrs = support_descriptors_list ();
> +    support_descriptors_dump (descrs, "info:  ", stdout);

Are you sure you need two spaces here? --------^^

The same again few lines below.

Otherwise I can confirm that it builds and runs correctly on x86_64
and there are more reviews from Carlos and Dmitry.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]