This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] posix: Do not include testcases.h, ptestcases.h in source tree
- From: Andreas Schwab <schwab at suse dot de>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 29 Nov 2018 10:34:23 +0100
- Subject: Re: [PATCH] posix: Do not include testcases.h, ptestcases.h in source tree
- References: <87bm69asdf.fsf@oldenburg.str.redhat.com>
On Nov 28 2018, Florian Weimer <fweimer@redhat.com> wrote:
> @@ -261,13 +261,15 @@ bug-glob1-ARGS = "$(objpfx)"
> tst-execvp3-ARGS = --test-dir=$(objpfx)
> CFLAGS-tst-spawn3.c += -DOBJPFX=\"$(objpfx)\"
>
> -testcases.h: TESTS TESTS2C.sed
> +$(objpfx)testcases.h: TESTS TESTS2C.sed
> LC_ALL=C sed -f TESTS2C.sed < $< > $@T
> - mv -f $@T $@
> + $(move-if-change) $@T $@
> +$(objpfx)runtests.o: $(objpfx)testcases.h
You should not use move-if-change without a stamp file. But why do you
need it in the first place?
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."