This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Enable VDSO on static on aarch64.


"Szabolcs Nagy" <Szabolcs.Nagy@arm.com> writes:

> On 24/11/18 23:24, Rafael Ávila de Espíndola wrote:
>> From: Rafael Avila de Espindola <rafael@espindo.la>
>>
>
> OK to commit with commit title:
>
> Enable VDSO for static linking on aarch64
>
> or equivalent.

I am OK with that message. Could you please commit it?

>>         [BZ #19767]
>>         * sysdeps/unix/sysv/linux/aarch64/init-first.c: remove #ifdef SHARED.
>>         * sysdeps/unix/sysv/linux/aarch64/libc-vdso.h: remove #ifdef SHARED.
>>         * sysdeps/unix/sysv/linux/aarch64/sysdep.h: define ALWAYS_USE_VSYSCALL.
>>
>
> i think this is not the standard changelog style
> (uppercase sentence, defined entity in () after filename).

I think the () are for the function/class, no? I see

* sysdeps/ia64/fpu/e_log2.S: Add versioned symbols.

but

* sysdeps/ieee754/dbl-64/e_log2.c (__ieee754_log2): Rename to __log2
  and add necessary aliases.

An updated ChangeLog is

2018-11-26  Rafael Ávila de Espíndola  <rafael@espindo.la>
        [BZ #19767]
        * sysdeps/unix/sysv/linux/aarch64/init-first.c: Remove #ifdef SHARED.
        * sysdeps/unix/sysv/linux/aarch64/libc-vdso.h: Remove #ifdef SHARED.
        * sysdeps/unix/sysv/linux/aarch64/sysdep.h: Define ALWAYS_USE_VSYSCALL.

Thanks,
Rafael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]