This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v5 00/14] port C-SKY to glibc
On Wed, Nov 21, 2018 at 6:01 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Wed, 21 Nov 2018, Mao Han wrote:
>
> > I'v modified patch 14/14 to a generic version with __NR3264_fstatat
> > conditionals (in the attachment). It is tested in the same environment
> > as patch V5 and got same result, but have't test fstat64 path yet.
>
> Thanks, this is the sort of thing I'm looking for, but I'm concerned about
> the use of __NR3264_fstatat. As I understand, that's an internal
> implementation detail of the asm-generic unistd.h; it shouldn't be
> considered something stable that will reliably be there in future kernel
> versions. Rather, the stable interface from asm/unistd.h is the
> __NR_<syscall> macros for each <syscall> provided by the kernel. So I
> think the #ifdef conditionals need to be on the actual syscalls used in
> each case (e.g. you'd condition on __NR_fstat64 when using fstat64 in the
> existing INLINE_SYSCALL use). In statx_cp.c you'll need to find some stat
> syscall to condition on that's present on all existing architectures, as
> the aim is that no existing glibc architecture should get any code
> compiled from that file (which you could check using
> build-many-glibcs.py).
Sorry, that was my mistake. __NR3264_fstatat and the related macros
will be gone in 4.20, I just haven't forwarded the patch to hide them
for csky and other statx() based architectures.
Arnd