This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] ld.so: command argument "--preload"

From: Florian Weimer <fweimer at redhat dot com>
To: David Newall <glibc at davidnewall dot com>
Cc: Carlos O'Donell <carlos at redhat dot com>, libc-alpha at sourceware dot org
Date: Wed, 07 Nov 2018 15:06:09 +0100
Subject: Re: [PATCH] ld.so: command argument "--preload"
References: <322fb70a-9c0e-100b-4366-dfa7e5134aa5@davidnewall.com> <265bec63-9875-7268-2199-c7e133b2298e@davidnewall.com> <874ldb7gxp.fsf@oldenburg.str.redhat.com> <5f79f366-d687-583f-940c-36c169bd34a9@davidnewall.com> <cfd15aee-c960-0599-b053-d36ce40c9707@redhat.com> <fe18f63f-0b38-361b-17a0-64820e013bc5@davidnewall.com> <87sh0eqssf.fsf@oldenburg.str.redhat.com> <8816b7fc-d798-42ee-de51-d1de56e6887c@davidnewall.com> <87zhuljiev.fsf@oldenburg.str.redhat.com> <43265e8e-956a-f895-6c04-8cd6898a8c97@davidnewall.com> <877ehphv2a.fsf@oldenburg.str.redhat.com> <2e1f89d3-9718-50ca-328c-b4b82b1974d4@davidnewall.com>

* David Newall:

> On 8/11/18 12:02 am, Florian Weimer wrote:
>>>   +tst-rtld-preload-OBJS =  $(subst $(empty) ,:,$(strip
>>> $(preloadtest-preloads:=.so)))
>>> +$(objpfx)tst-rtld-preload.out: tst-rtld-preload.sh $(objpfx)ld.so \
>>> +			       $(objpfx)preloadtest
>> Missing dependency on the objects in $(tst-rtld-preload-OBJS), I think.

> I think not.  This is the same as preloadtest-ENV (without
> "LD_PRELOAD=").  Is it okay?  Should I have included a comment to
> explain this?

preloadtest.out has this:

$(objpfx)preloadtest.out: $(preloadtest-preloads:%=$(objpfx)%.so)
preloadtest-ENV = \
  LD_PRELOAD=$(subst $(empty) ,:,$(strip $(preloadtest-preloads:=.so)))

So I think you should add $(preloadtest-preloads:%=$(objpfx)%.so) as
well.

Thanks,
Florian

References:
- Re: [PATCH] ld.so: command argument "--preload"
  - From: David Newall
- Re: [PATCH] ld.so: command argument "--preload"
  - From: Carlos O'Donell
- Re: [PATCH] ld.so: command argument "--preload"
  - From: David Newall
- Re: [PATCH] ld.so: command argument "--preload"
  - From: Florian Weimer
- Re: [PATCH] ld.so: command argument "--preload"
  - From: David Newall
- Re: [PATCH] ld.so: command argument "--preload"
  - From: Florian Weimer
- Re: [PATCH] ld.so: command argument "--preload"
  - From: David Newall
- Re: [PATCH] ld.so: command argument "--preload"
  - From: Florian Weimer
- Re: [PATCH] ld.so: command argument "--preload"
  - From: David Newall

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]