This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] support: Implement TEST_COMPARE_STRING
* Szabolcs Nagy:
> On 07/11/18 11:36, Gabriel F. T. Gomes wrote:
>> On Wed, 07 Nov 2018, Florian Weimer wrote:
>>> * Gabriel F. T. Gomes:
>>>>> +/* Compare the strings LEFT and RIGHT and report a test failure if
>>>>> + they are different. Also report failure if one of the arguments is
>>>>> + a null pointer and the other is not. The strings should be
>>>>> + reasonably short because on mismatch, both are printed. */
>>>>> +#define TEST_COMPARE_STRING(left, right) \
>>>>> + (support_test_compare_string (left, right, __FILE__, __LINE__, \
>>>>> + #left, #right))
>>>> Spaces instead of tabs.
>>> I wasn't aware that we have a policy to use tabs. Most of my changes
>>> involving new files do not use tabs. 8-/
>> Oh, maybe we don't. Now I feel embarrassed that I complained about it so
>> many times.
> that's news to me,
> why is there an awkward mix of space and tab
> indentation everywhere in the code then?
It's the Emacs default. I don't know about vim.
Have we ever discussed changing it?