This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: V6 [PATCH] x86: Add <sys/platform/x86.h>
On Tue, 30 Oct 2018, H.J. Lu wrote:
> On Tue, Oct 30, 2018 at 11:15 AM Joseph Myers <joseph@codesourcery.com> wrote:
> >
> > On Tue, 30 Oct 2018, H.J. Lu wrote:
> >
> > > I'd like to add this C/C++ feature to glibc. If there is no objection, I will
> > > check it in tomorrow.
> >
> > I object: it's clear you don't have consensus for this feature in its
> > presently proposed form.
>
> The only concern so far is this feature is C/C++ only. My understanding
> is that it is perfectly OK to have <sys/platform/cpu.h> with C/C++
> only features.
> Am I correct?
When we're adding new APIs it's necessary to achieve consensus on what the
API should be - especially if the API is a glibc-specific invention, as
here. Even with a more general consensus on C/C++ only features in such a
header, that wouldn't mean consensus in that regard for this particular
feature. We don't work by allowing a day for objections and then checking
things in; consensus-building on an API design is a slower and more
collaborative process than that. This feature should not be checked in
without someone else having reviewed the whole discussion and the patch
and considered carefully whether consensus has been reached on all issues
and the patch is the proper way of implementing the proper API.
--
Joseph S. Myers
joseph@codesourcery.com