This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] MIPS: Use `.set mips2' to emulate LL/SC for the R5900 too
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: Fredrik Noring <noring at nocrew dot org>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org, Jürgen Urban <JuergenUrban at gmx dot de>
- Date: Tue, 30 Oct 2018 21:06:15 +0000 (GMT)
- Subject: Re: [PATCH v2] MIPS: Use `.set mips2' to emulate LL/SC for the R5900 too
- References: <3fb8c58bc662b93e68a992adfb099ad233b40ea2.1540925714.git.noring@nocrew.org>
Hi Fredrik,
> It turns out that `.set arch=mips' isn't needed, so the patch can be
> simplified. Please find the updated v2 patch here.
FAOD, it was me who suggested that `.set arch=mips2' was required, while
indeed existing `.set mips2' is just as good and does not have to be
changed.
For some reason I misremembered that with GAS `.set mipsX' only overrides
the ISA level used for assembly and leaves the original CPU architecture
intact, while indeed both `.set mipsX' and `.set arch=mipsX' override both
settings and are equivalent to each other. Sorry to cause this confusion.
This version is:
Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>
Maciej